How string concatenation creates vulnerabilities in SQL - Performance & Efficiency

Time Complexity: How string concatenation creates vulnerabilities

O(n^2)

Understanding Time Complexity

We want to see how building SQL commands by joining strings affects how long the database takes to run them.

Specifically, we ask: How does the work grow when we add more parts to the command?

Scenario Under Consideration

Analyze the time complexity of the following code snippet.

DECLARE @sql NVARCHAR(MAX);
SET @sql = 'SELECT * FROM Users WHERE 1=1';

IF @name IS NOT NULL
  SET @sql = @sql + ' AND name = ''' + @name + '''';

IF @age IS NOT NULL
  SET @sql = @sql + ' AND age = ' + CAST(@age AS NVARCHAR(10));

EXEC sp_executesql @sql;
    

This code builds a SQL query by joining strings based on input values, then runs it.

Identify Repeating Operations

Identify the loops, recursion, array traversals that repeat.

• Primary operation: Concatenating strings to build the query.
• How many times: Once per condition checked, but string length grows with each addition.

How Execution Grows With Input

As more conditions are added, the query string gets longer, so concatenation takes more time.

Input Size (conditions)	Approx. Operations
1	Small string concatenation
5	Medium string concatenation, longer query
20	Much longer string concatenation, more work

Pattern observation: The time to build the query grows roughly with the total length of the string being concatenated.

Final Time Complexity

Time Complexity: O(n^2)

This means the time to build the query grows quadratically with the number of parts added.

Common Mistake

[X] Wrong: "Concatenating strings is always fast and safe regardless of input size."

[OK] Correct: As the query grows, concatenation takes more time and can cause security risks if inputs are not handled safely.

Interview Connect

Understanding how building queries with string joins affects performance and security shows your care for writing safe and efficient database code.

Self-Check

"What if we used parameterized queries instead of string concatenation? How would the time complexity and security change?"

Practice

1. What is the main security risk when using string concatenation to build SQL queries?

easy

A. It can allow attackers to inject malicious SQL code.

B. It makes queries run faster than parameterized queries.

C. It automatically encrypts user input.

D. It prevents any syntax errors in the query.

Solution

1. Step 1: Understand string concatenation in SQL queries

   Concatenating user input directly into SQL commands can mix code and data.

2. Step 2: Recognize the risk of SQL injection

   This mixing allows attackers to add harmful SQL commands, called SQL injection.

3. Final Answer:

   It can allow attackers to inject malicious SQL code. -> Option A

4. Quick Check:

   SQL injection risk = A [OK]

Hint: Concatenating user input risks injection attacks [OK]

Common Mistakes:

• Thinking concatenation speeds up queries
• Believing concatenation encrypts input
• Assuming concatenation prevents errors

2. Which of the following SQL query constructions using string concatenation is syntactically correct?

easy

A. SELECT * FROM users WHERE name = '\'' + userName + '\'';

B. SELECT * FROM users WHERE name = '\'' + userName + '\'

C. SELECT * FROM users WHERE name = ' + userName + "';

D. SELECT * FROM users WHERE name = '\'' + userName + "';

Solution

1. Step 1: Check string delimiters and concatenation syntax

   In SQL, string literals are enclosed in single quotes. Concatenation in code requires proper quotes and plus signs.

2. Step 2: Identify correct syntax for concatenation in code

   SELECT * FROM users WHERE name = '\'' + userName + '\''; correctly escapes single quotes for SQL string literals and concatenates userName with plus signs.

3. Final Answer:

   "SELECT * FROM users WHERE name = '\'' + userName + '\'';" -> Option A

4. Quick Check:

   Proper quotes and concatenation = A [OK]

Hint: Look for matching quotes and plus signs [OK]

Common Mistakes:

• Missing semicolon at end
• Mismatched or missing quotes
• Using wrong concatenation operators

3. Given the query built by concatenation: "SELECT * FROM users WHERE username = '" + input + "';" and input = admin' OR '1'='1, what will be the effect when executed?

medium

A. Returns only the user with username 'admin'.

B. Returns all users because the WHERE clause is always true.

C. Causes a syntax error and query fails.

D. Returns no rows because input is invalid.

Solution

1. Step 1: Substitute input into the query string

   The query becomes: SELECT * FROM users WHERE username = 'admin' OR '1'='1';

2. Step 2: Analyze the WHERE clause logic

   The condition '1'='1' is always true, so the WHERE clause matches all rows.

3. Final Answer:

   Returns all users because the WHERE clause is always true. -> Option B

4. Quick Check:

   Injected OR '1'='1' returns all rows = D [OK]

Hint: Injected OR '1'='1' makes WHERE always true [OK]

Common Mistakes:

• Thinking it returns only 'admin'
• Assuming syntax error occurs
• Believing no rows are returned

4. Identify the error in this SQL query construction using string concatenation: query = "SELECT * FROM users WHERE id = " + userId; where userId is a string input.

medium

A. Using plus sign for concatenation is invalid in SQL.

B. No error; query is correct.

C. Query is safe from SQL injection.

D. Missing quotes around userId value causing syntax error.

Solution

1. Step 1: Check how userId is inserted in query

   The query concatenates userId without quotes, so if userId is a string, SQL syntax breaks.

2. Step 2: Understand SQL string literal requirements

   String values must be enclosed in single quotes in SQL to be valid.

3. Final Answer:

   Missing quotes around userId value causing syntax error. -> Option D

4. Quick Check:

   String values need quotes = B [OK]

Hint: String inputs need quotes in SQL queries [OK]

Common Mistakes:

• Thinking plus sign is invalid in code
• Assuming query is safe from injection
• Ignoring missing quotes causes errors

5. You want to prevent SQL injection when building queries with user input. Which approach best avoids vulnerabilities caused by string concatenation?

hard

A. Remove all spaces from user input before concatenation.

B. Escape all single quotes in user input manually before concatenation.

C. Use parameterized queries or prepared statements instead of concatenation.

D. Convert user input to uppercase before concatenation.

Solution

1. Step 1: Understand the problem with string concatenation

   Concatenation mixes code and data, allowing injection if input is malicious.

2. Step 2: Identify secure alternatives

   Parameterized queries separate code from data, preventing injection regardless of input.

3. Final Answer:

   Use parameterized queries or prepared statements instead of concatenation. -> Option C

4. Quick Check:

   Parameterized queries prevent injection = C [OK]

Hint: Always prefer parameterized queries over concatenation [OK]

Common Mistakes:

• Relying on manual escaping which is error-prone
• Thinking removing spaces prevents injection
• Assuming uppercase conversion secures input