File upload security risks in PHP - Time & Space Complexity
When handling file uploads in PHP, it's important to understand how the code's work grows as more files or larger files are processed.
We want to see how the time to check and save files changes with input size.
Analyze the time complexity of the following code snippet.
// Process multiple uploaded files
foreach ($_FILES['uploads']['tmp_name'] as $index => $tmpName) {
$fileName = $_FILES['uploads']['name'][$index];
$fileType = $_FILES['uploads']['type'][$index];
// Simple check for allowed types
if (in_array($fileType, ['image/jpeg', 'image/png'])) {
move_uploaded_file($tmpName, '/uploads/' . $fileName);
}
}
This code loops through uploaded files, checks their type, and moves allowed files to a folder.
Identify the loops, recursion, array traversals that repeat.
- Primary operation: Looping through each uploaded file to check and move it.
- How many times: Once for each file uploaded (depends on number of files).
As the number of files increases, the code does more checks and moves more files.
| Input Size (n) | Approx. Operations |
|---|---|
| 10 | About 10 checks and moves |
| 100 | About 100 checks and moves |
| 1000 | About 1000 checks and moves |
Pattern observation: The work grows directly with the number of files; double the files, double the work.
Time Complexity: O(n)
This means the time to process files grows linearly with how many files are uploaded.
[X] Wrong: "Checking file types or moving files happens instantly no matter how many files there are."
[OK] Correct: Each file requires a check and a move operation, so more files mean more work and more time.
Understanding how file upload handling scales helps you write safer and more efficient code, a skill valuable in many real projects.
"What if we added a nested loop to scan inside each file's contents? How would the time complexity change?"
Practice
Solution
Step 1: Understand file upload risks
Malicious users can upload harmful scripts if file types are not checked.Step 2: Importance of validation
Validating file types helps block dangerous files and protects the server.Final Answer:
To prevent users from uploading harmful scripts disguised as files -> Option DQuick Check:
File type validation = prevent harmful uploads [OK]
- Ignoring file type validation
- Assuming all files are safe
- Only checking file extensions without content
Solution
Step 1: Identify function purpose
mime_content_type() returns the MIME type of a file, useful for validation.Step 2: Compare with other functions
move_uploaded_file() moves files, file_get_contents() reads content, is_uploaded_file() checks upload status.Final Answer:
mime_content_type() -> Option AQuick Check:
Check MIME type = mime_content_type() [OK]
- Using move_uploaded_file() to check file type
- Confusing file_get_contents() with type checking
- Not verifying MIME type at all
image.jpg with size 5MB, but the allowed max size is 2MB?$maxSize = 2 * 1024 * 1024; // 2MB
if ($_FILES['file']['size'] > $maxSize) {
echo 'File too large';
} else {
echo 'Upload successful';
}Solution
Step 1: Understand size check logic
The code compares uploaded file size to maxSize (2MB).Step 2: Compare actual file size
Uploaded file is 5MB, which is greater than 2MB, so condition is true.Final Answer:
File too large -> Option AQuick Check:
5MB > 2MB triggers 'File too large' [OK]
- Confusing bytes and megabytes
- Not multiplying correctly for max size
- Ignoring file size check
if (move_uploaded_file($_FILES['file']['tmp_name'], 'uploads/' . $_FILES['file']['name'])) {
echo 'Upload successful';
} else {
echo 'Upload failed';
}Solution
Step 1: Check file size validation
Code does not check file size before moving the file.Step 2: Check filename handling
Using original filename directly risks overwriting and security issues.Step 3: Check upload method validation
Missing is_uploaded_file() check to confirm HTTP POST upload.Final Answer:
All of the above -> Option BQuick Check:
Missing size, sanitization, and upload checks [OK]
- Ignoring filename sanitization
- Not verifying upload method
- Skipping file size validation
Solution
Step 1: Validate file type and size
Use mime_content_type() to confirm PNG and check size under 1MB.Step 2: Rename file and secure storage
Rename with uniqid() to avoid conflicts and save outside web root to prevent script execution.Final Answer:
Check MIME type with mime_content_type(), limit size, rename with uniqid(), save outside web root -> Option CQuick Check:
Validate type & size + rename + secure storage [OK]
- Relying only on file extension
- Saving files in web root without restrictions
- Not renaming files uniquely
Ready to prove it?
Pass the test and this pattern moves unknown
