Code review as testing in Testing Fundamentals - Framework Patterns

Framework Mode - Code review as testing

Folder Structure for Code Review Artifacts

code-review-project/
├── reviews/
│   ├── feature-xyz-review.md
│   ├── bugfix-123-review.md
│   └── performance-improvements-review.md
├── guidelines/
│   ├── code-review-checklist.md
│   └── best-practices.md
├── tools/
│   ├── static-analysis-scripts/
│   └── review-templates/
└── README.md

This structure organizes code review documents, guidelines, and supporting tools.

Layers in Code Review as Testing

• Review Guidelines Layer: Defines what to check (style, logic, security).
• Review Artifacts Layer: Stores review comments, checklists, and reports.
• Automation Tools Layer: Includes static analysis scripts and templates to assist reviews.
• Collaboration Layer: Platforms like GitHub or GitLab where reviews happen.

Each layer supports thorough examination of code before it reaches production.

Configuration Patterns for Code Review

• Review Checklist Configuration: Maintain a checklist file to standardize review points.
• Environment Setup: Configure IDEs and tools with linters and formatters matching project rules.
• Access Control: Define who can approve or request changes in code reviews.
• Automation Integration: Configure CI to run static analysis and block merges on failures.

Reporting and Integration

• Review Comments: Inline comments on code diffs provide clear feedback.
• Summary Reports: Generate reports summarizing review findings and action items.
• CI/CD Integration: Block merges if critical review issues exist, ensuring quality gates.
• Metrics Tracking: Track review times, defect density, and reviewer participation for process improvement.

Best Practices for Code Review as Testing

• Use a Standard Checklist: Ensures consistent coverage of important aspects.
• Keep Reviews Small and Focused: Easier to find issues and faster feedback.
• Automate Where Possible: Use linters and static analysis to catch common problems early.
• Encourage Positive, Constructive Feedback: Helps maintain team morale and learning.
• Integrate Reviews into CI/CD: Prevents bad code from reaching production.

Self-Check Question

Where in this folder structure would you add a new checklist for security-specific code reviews?

Key Result

Code review as testing uses structured guidelines, collaboration, and automation to catch defects early and improve code quality.

Practice

1. What is the main purpose of code review in software testing?

easy

A. To find bugs and improve code quality before running the code

B. To write new features faster

C. To deploy code to production immediately

D. To replace automated testing completely

Solution

1. Step 1: Understand code review purpose

   Code review is done to check code manually for errors and improvements before execution.

2. Step 2: Compare options with purpose

   Only To find bugs and improve code quality before running the code matches the goal of finding bugs and improving quality before running code.

3. Final Answer:

   To find bugs and improve code quality before running the code -> Option A

4. Quick Check:

   Code review = find bugs early [OK]

Hint: Code review finds bugs before running code [OK]

Common Mistakes:

• Thinking code review replaces automated tests
• Believing code review speeds up deployment
• Confusing code review with coding new features

2. Which of the following is the correct way to give feedback during a code review?

easy

A. Provide clear, constructive comments with examples

B. Only comment if you find a syntax error

C. Ignore small mistakes to save time

D. Say 'This code is bad' without explanation

Solution

1. Step 1: Understand effective feedback

   Good feedback is clear, constructive, and helps improve code with examples.

2. Step 2: Evaluate options

   Provide clear, constructive comments with examples matches this approach; others are either rude, incomplete, or ignore issues.

3. Final Answer:

   Provide clear, constructive comments with examples -> Option A

4. Quick Check:

   Constructive feedback = clear + helpful [OK]

Hint: Be clear and helpful in feedback [OK]

Common Mistakes:

• Giving vague or rude comments
• Ignoring minor but important issues
• Only pointing out syntax errors

3. During a code review, you see this Python snippet:

def add_numbers(a, b):
    return a + b

result = add_numbers(2, '3')
print(result)

What will happen when this code runs?

medium

A. It will print 5

B. It will print 23

C. It will raise a TypeError

D. It will print null

Solution

1. Step 1: Analyze function call with mixed types

   The function adds an integer 2 and a string '3', which is invalid in Python.

2. Step 2: Understand Python behavior on adding int and str

   Python raises a TypeError when trying to add int and str directly.

3. Final Answer:

   It will raise a TypeError -> Option C

4. Quick Check:

   int + str = TypeError [OK]

Hint: Adding int and string causes TypeError in Python [OK]

Common Mistakes:

• Assuming Python converts string to int automatically
• Thinking it concatenates as strings
• Expecting numeric addition without error

4. You find this JavaScript code during review:

function multiply(x, y) {
  return x * y;
}

console.log(multiply(5));

What is the issue and how to fix it?

medium

A. multiply is missing one argument; fix by passing two arguments

B. multiply returns NaN; fix by setting default value for y

C. No issue; it prints 5

D. multiply throws error; fix by wrapping in try-catch

Solution

1. Step 1: Check function call with missing argument

   Calling multiply(5) passes only one argument; y is undefined.

2. Step 2: Understand JavaScript behavior multiplying number and undefined

   Multiplying number by undefined results in NaN (Not a Number).

3. Step 3: Fix by setting default value for y

   Use default parameter like function multiply(x, y = 1) to avoid NaN.

4. Final Answer:

   multiply returns NaN; fix by setting default value for y -> Option B

5. Quick Check:

   Missing arg causes NaN; default fixes [OK]

Hint: Missing JS args can cause NaN; use defaults [OK]

Common Mistakes:

• Assuming missing argument is zero
• Expecting error instead of NaN
• Ignoring default parameter usage

5. You review this Python code snippet:

data = [1, 2, 3, 4, 5]
result = {x: x*2 for x in data if x > 2}
result[3] = 10
print(result)

What is the final output and what does it teach about code review?

hard

A. {3: 6, 4: 8, 5: 10} - Code review helps spot logic and mutation issues

B. {1: 2, 2: 4, 3: 6, 4: 8, 5: 10} - Code review ensures all data processed

C. Error - Code review prevents runtime exceptions

D. {3: 10, 4: 8, 5: 10} - Code review helps catch unintended data changes

Solution

1. Step 1: Understand dictionary comprehension with condition

   Creates dict with keys 3,4,5 and values doubled: {3:6,4:8,5:10}.

2. Step 2: Note mutation of result[3]

   Code changes key 3's value from 6 to 10 explicitly.

3. Step 3: Final output and lesson

   Prints {3:10,4:8,5:10}. Code review helps catch such unintended mutations.

4. Final Answer:

   {3: 10, 4: 8, 5: 10} - Code review helps catch unintended data changes -> Option D

5. Quick Check:

   Mutation changes dict; review catches it [OK]

Hint: Check data changes carefully during review [OK]

Common Mistakes:

• Ignoring dictionary mutation after comprehension
• Assuming all data keys included
• Expecting error instead of changed output