BST Inorder Successor in DSA C - Time & Space Complexity

Time Complexity: BST Inorder Successor

O(h)

Understanding Time Complexity

We want to understand how long it takes to find the next bigger value in a Binary Search Tree (BST).

How does the time grow as the tree gets bigger?

Scenario Under Consideration

Analyze the time complexity of the following code snippet.

// Find inorder successor in BST
Node* inorderSuccessor(Node* root, Node* p) {
    if (p->right != NULL) {
        Node* curr = p->right;
        while (curr->left != NULL) {
            curr = curr->left;
        }
        return curr;
    }
    Node* succ = NULL;
    while (root != NULL) {
        if (p->val < root->val) {
            succ = root;
            root = root->left;
        } else {
            root = root->right;
        }
    }
    return succ;
}
    

This code finds the next bigger node after a given node in a BST.

Identify Repeating Operations

Look for loops or repeated steps.

• Primary operation: Traversing down the tree nodes either to the left or right.
• How many times: At most once down a path from root or from the right child of the node.

How Execution Grows With Input

The time depends on the height of the tree, not the total number of nodes.

Input Size (n)	Approx. Operations (height h)
10	Up to 4-5 steps (if tree is balanced)
100	Up to 7 steps
1000	Up to 10 steps

Pattern observation: Operations grow slowly as tree height grows, usually about log n steps.

Final Time Complexity

Time Complexity: O(h)

This means the time to find the successor grows with the tree height, which is usually much smaller than total nodes.

Common Mistake

[X] Wrong: "Finding the successor always takes time proportional to the total number of nodes."

[OK] Correct: We only follow one path down the tree, not visit all nodes, so time depends on height, not total nodes.

Interview Connect

Understanding this helps you explain how tree structure affects search speed, a key skill for many coding problems.

Self-Check

"What if the BST is not balanced and becomes a linked list? How would the time complexity change?"

Practice

1. What is the inorder successor of a node in a Binary Search Tree (BST)?

easy

A. The node with the largest key smaller than the given node's key

B. The node with the smallest key greater than the given node's key

C. The left child of the given node

D. The right child of the given node

Solution

1. Step 1: Understand inorder traversal in BST

   Inorder traversal visits nodes in ascending order of their keys.

2. Step 2: Define inorder successor

   The inorder successor of a node is the next node visited after it in inorder traversal, which is the smallest node greater than it.

3. Final Answer:

   The node with the smallest key greater than the given node's key -> Option B

4. Quick Check:

   Inorder successor = next bigger node [OK]

Hint: Inorder successor is next bigger node in sorted order [OK]

Common Mistakes:

• Confusing successor with predecessor
• Thinking successor is always right child
• Assuming successor is left child

2. Which of the following C function signatures correctly represents a function to find the inorder successor of a BST node?

easy

A. struct Node* inorderSuccessor(struct Node* root, struct Node* n);

B. int inorderSuccessor(int root, int n);

C. void inorderSuccessor(struct Node* root);

D. struct Node inorderSuccessor(struct Node n);

Solution

1. Step 1: Analyze function parameters

   The function needs the BST root and the node to find successor for, both as pointers.

2. Step 2: Analyze return type

   It should return a pointer to the successor node, so return type is struct Node*.

3. Final Answer:

   struct Node* inorderSuccessor(struct Node* root, struct Node* n); -> Option A

4. Quick Check:

   Correct signature uses pointers for nodes [OK]

Hint: Use pointers for nodes and return pointer to successor [OK]

Common Mistakes:

• Using int instead of struct Node*
• Missing node parameter
• Returning struct Node by value

3. Given the BST below and the node with value 15, what is the inorder successor?

        20
       /  \
     10    30
       \     \
       15    40

medium

A. 10

B. 30

C. 20

D. 40

Solution

1. Step 1: Locate node 15 and find its right subtree

   Node 15 has no right child, so successor is an ancestor.

2. Step 2: Move up to find the lowest ancestor greater than 15

   Parent 10 is less than 15, move up to 20 which is greater than 15.

3. Final Answer:

   20 -> Option C

4. Quick Check:

   Next bigger after 15 is 20 [OK]

Hint: If no right child, successor is nearest bigger ancestor [OK]

Common Mistakes:

• Choosing right child 30 incorrectly
• Choosing smaller ancestor 10
• Confusing successor with predecessor

4. Consider this buggy C code snippet to find the inorder successor of a node in BST:

struct Node* inorderSuccessor(struct Node* root, struct Node* n) {
    if (n->right != NULL) {
        struct Node* temp = n->right;
        while (temp->left != NULL) {
            temp = temp->left;
        }
        return temp;
    }
    struct Node* succ = NULL;
    while (root != NULL) {
        if (n->data < root->data) {
            succ = root;
            root = root->left;
        } else {
            root = root->right;
        }
    }
    return succ;
}

What is the main logical error in this code?

medium

A. It incorrectly updates successor when moving right

B. It returns the wrong node when node has right child

C. It uses a while loop instead of recursion

D. It does not handle the case when node has no right child

Solution

1. Step 1: Check handling of right child

   Code correctly finds leftmost node in right subtree if right child exists.

2. Step 2: Check updating successor when moving right

   In the else branch (n->data >= root->data), it incorrectly sets succ = root before moving right. Successor should NOT be updated when going right, as n is in (or at) the right subtree.

3. Step 3: Identify error

   The main logical error is incorrectly updating the successor when traversing right.

4. Final Answer:

   It incorrectly updates successor when moving right -> Option A

5. Quick Check:

   Successor updates only on left moves [OK]

Hint: Successor updates only when moving left in BST [OK]

Common Mistakes:

• Thinking recursion is required
• Updating successor when moving right
• Ignoring right subtree case

5. You have a BST and want to find the inorder successor of the node with value 25. The BST is:

         20
        /  \
      10    30
     /  \  /  \
    5  15 25  40

If the node with value 25 has no right child, what is the inorder successor and why?

hard

A. 20, because it is the root

B. 40, because it is the right child of 30

C. No successor, because 25 has no right child

D. 30, because it is the lowest ancestor greater than 25

Solution

1. Step 1: Check if node 25 has right child

   Node 25 has no right child, so successor is an ancestor.

2. Step 2: Find lowest ancestor greater than 25

   Ancestor 30 is greater than 25 and is the lowest such ancestor.

3. Final Answer:

   30, because it is the lowest ancestor greater than 25 -> Option D

4. Quick Check:

   Successor = nearest bigger ancestor [OK]

Hint: If no right child, successor is nearest bigger ancestor [OK]

Common Mistakes:

• Choosing right child 40 incorrectly
• Saying no successor exists
• Choosing root 20 incorrectly